Improved lfp buffer handling (remove virtually all callbacks)#101
Merged
BrendanKelly84213 merged 1 commit intomain_protectedfrom Mar 17, 2026
Merged
Improved lfp buffer handling (remove virtually all callbacks)#101BrendanKelly84213 merged 1 commit intomain_protectedfrom
BrendanKelly84213 merged 1 commit intomain_protectedfrom
Conversation
alexkar598
force-pushed
the
lfp_buffers
branch
3 times, most recently
from
9191c30 to
8b7b2ac
Compare
BrendanKelly84213
approved these changes
Mar 17, 2026
Contributor
BrendanKelly84213
left a comment
BrendanKelly84213
left a comment
There was a problem hiding this comment.
works great thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (tell us what you changes or added or removed please)
The streamed API was cute in theory but doesn't work out over I2C. It may return at a later date in a better state. For now, everything must be encoded to fixed size buffers.
A few bugs in LFP were corrected
As a bonus, open_console.sh now reloads if the elf file is updated
How to test (if any tests done)
Example code was updated
Checklist