Skip to content

Conversation

naga-karthik
Copy link
Collaborator

@naga-karthik naga-karthik commented Apr 7, 2025

This PR aims to provide instructions for training the contrast agonstic model, which can be found in the README.

How to test the PR:

  • Clone the repo and checkout to my branch nk/clean-repo
  • Follow the instructions in the README and update the necessary variables in scripts/train_contrast_agnostic.sh

Resolves #145 #143 #127 #124

@naga-karthik naga-karthik changed the title Instructions to Add instructions to train contrast-agnostic model Apr 7, 2025
@valosekj
Copy link
Member

valosekj commented Apr 14, 2025

Thanks for the PR!

I'm getting an error when downloading the data-multi-subject dataset. I guess that the issue is that data-multi-subject is on available on our git-annex server but on Amazon.

image

we might need to use these install instructions: https://github.com/spine-generic/data-multi-subject?tab=readme-ov-file#download

trying with sci-colorado for now

@valosekj
Copy link
Member

Just so we don't forget

image

@naga-karthik
Copy link
Collaborator Author

naga-karthik commented Apr 14, 2025

@valosekj thanks for the screenshot! I fixed the issue #147 (comment) in commit 4525309, can you please try running it on data-multi-subject now?

cd contrast-agnostic-softseg-spinalcord/nnUnet
pip install -r requirements.txt
cd contrast-agnostic-softseg-spinalcord
pip install -r nnUnet/requirements.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intentional that nnUnet/requirements.txt does not install the nnUNet itself?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without nnUNet installed in the contrast_agnostic env, I obviously get:

image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it is intentional, I thikn nnunet installation should be done outside the contrast-agnostic repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update requirements after cleaning the repo

2 participants