feat(notifications): added an opt-in by default setting for email notifications #4132
+42
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricecrackerfiend
requested review from
OwsleyJr,
TheCatLady,
danshilm and
sct
as code owners
1 task
…ifications Introduce a new server setting that changes the default enablement of email notifications for users. If this setting is enabled, users who have not configured email notifications will not receive email notifications by default. If this setting is disabled, behaviour remains the same as before. fix sct#4033
ricecrackerfiend
force-pushed
the
make-email-auto-opt-in-configurable
branch
from
512ce7b to
71184c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduce a new server setting that changes the default enablement of email notifications for users.
If this setting is enabled, users who have not configured email notifications will not receive email notifications by default. If this setting is disabled, behaviour remains the same as before.
I made this change because I find that users can often be annoyed when receiving emails they haven't consented to receiving. Rather than enforcing a default consent across all Overseerr instances, it made more sense to leave that decision up to the server owner. Now server owners can decide whether they require their users to consent/opt-in to receiving email notifications.
Screenshot (if UI-related)
To-Dos
yarn buildyarn i18n:extractIssues Fixed or Closed