-
-
Notifications
You must be signed in to change notification settings - Fork 567
feat: add option to Decline request with a Reason #4205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
Nice job! Hope to see that feature in jellyseerr as well. Thanks! |
|
@sct is there any chance to get that? i need it. And can the declined reason add to the E-Mail's? |
|
Cool looking PR! I think the decline reason button should probably be consolidated into the main decline button as a dropdown. Also not sure how I feel about the quick presets. Is there a limit to them and if not, what does it look like with a bunch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this Entity? Can we not just add this directly to the MediaRequest entity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably add a limit to the decline reason and validation for that here/backend. Not sure if I'm seeing it here
| <div className="space-y-3"> | ||
| <div className="text-sm font-medium text-gray-200"> | ||
| {intl.formatMessage(messages.quickReasons)} | ||
| </div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably shouldn't show if there are no presets.
|
should this not been moved to the new Seerr?? |
Adds Decline with Reasons feature, includes custom message and saveable presets
Description
Adds new button next to existing Decline button that opens Decline with Reasons, presets are displayed that if clicked on immedaitely submit the form, meaning only one extra button press to add a preset reason. Custom text box with option to save as a preset for future use. Displays decline reason in Declined badge (truncated with tooltip for long messages/small screens) and also intergrated into notifications.
Screenshot (if UI-related)
To-Dos
yarn buildyarn i18n:extractIssues Fixed or Closed
#4184 , #2270 , #593