feat: Update Angular #1040
Open
feat: Update Angular #1040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@EliasVal is attempting to deploy a commit to the Scott's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
Author
|
It seems I broke a good part of the |
Author
|
Ight, I think I'm done here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated all dependencies to the latest (v21) Angular packages.This includes fixing ESLint, updating runners, and replacing@Injectwithinject,ngIfwith@if, mostly removing deprecations.The biggest deprecation left is substitutingprovideAnimationswithanimate.enterandanimate.leave.A few more things that would be good to do are usinginputsignals wherever necessary, adding members to methods, and retiring all decorators (except injectable, component, and directive, of course) in favor of the new control flowEDIT:
Since I was having issues with Zone.js and SCSS, I attempted to recreate the project from scratch to also align it with today's Angular.
It all seems to work. I got completely rid of anything deprecated, including
provideAnimations,toPromise, etc.I also moved the tests to a service and remove useless tests to more accurately display code coverage
Also, I don't really know how your CI pipeline really works, and I'm pretty sure this PR breaks it. With some guidance, I'll be happy fix it.
If this PR is deemed 'too big,' which is totally understandable, let me know.
Resolves #1035
Resolves #1039