📝 Added speed comparison to other data loaders #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #36 +/- ##
=======================================
Coverage 84.42% 84.42%
=======================================
Files 8 8
Lines 520 520
=======================================
Hits 439 439
Misses 81 81 🚀 New features to boost your workflow:
|
Zethson
reviewed
Sep 21, 2025
ilan-gold
requested changes
Sep 25, 2025
There was a problem hiding this comment.
- The notebook link for consolidating the runs i.e., "Benchmark results" does not work
- I really think this should be a notebook with no dependencies, assuming what you've posted here is supposed to be a quick-run (see point 1., I have no way of knowing). We should use
juvto create a self-contained notebook that has its dependnencies listed and can be run quickly modulo downloading a small dataset from lamin.
Comment on lines
+4
to
+5
| > This package does not have a stable API. However, we do not anticipate the on-disk format to change as it is simply an | ||
| > anndata file. |
There was a problem hiding this comment.
Suggested change
| > This package does not have a stable API. However, we do not anticipate the on-disk format to change as it is simply an | |
| > anndata file. | |
| > This package does not have a stable API. However, we do not anticipate the on-disk format to change as it is simply an anndata file. |
why the change?
Comment on lines
+106
to
+107
| For performance reasons, you should use our dataloader directly without wrapping it into a {class} | ||
| `torch.utils.data.dataloader`. |
There was a problem hiding this comment.
Suggested change
| For performance reasons, you should use our dataloader directly without wrapping it into a {class} | |
| `torch.utils.data.dataloader`. | |
| For performance reasons, you should use our dataloader directly without wrapping it into a {class}`torch.utils.data.dataloader`. |
Comment on lines
+115
to
+116
| If you are interested in contributing this feature to the project or leaning more, please get in touch | ||
| on [zulip](https://scverse.zulipchat.com/) or via the GitHub issues here. |
There was a problem hiding this comment.
Please resolve all these linebreak issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added speed comparison benchmarks against other data loaders to README.