fix: bring back zarr#21
Open
ilan-gold wants to merge 10 commits into
Open
Conversation
ilan-gold
commented
May 14, 2026
| }) | ||
| .collect(); | ||
| if starts.len() == selection.ndim() { | ||
| container.cache.clear(); |
Author
There was a problem hiding this comment.
I think this was a bug because shards can become stale when writing. We have the cache with the old shards, but then write But the cache thinks its already up to date despite the newly written chunks.
Co-authored-by: Philipp A. <flying-sheep@web.de>
flying-sheep
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure why it was removed but this would be awesome for "data producers"! Starting out with zarr v3 is awesome and really speeds everything up downstream. If I understood why it was removed I would be happy to help out with that going forward - for example maybe making the
ndarraydependency in the top levelCargo.tomlmight help keep everything in line?https://annbatch.readthedocs.io/en/stable/ makes extensive use of it and we are moving the python package to writing sharded v3 data by default: scverse/anndata#2368 when zarr is requested
cc @rob-p @noamteyssier