Skip to content

(chore): ensure views of anndata produce distinguishable view classes#1637

Draft
ilan-gold wants to merge 5 commits into
mainfrom
ig/view_class
Draft

(chore): ensure views of anndata produce distinguishable view classes#1637
ilan-gold wants to merge 5 commits into
mainfrom
ig/view_class

Conversation

@ilan-gold
Copy link
Copy Markdown
Contributor

  • Closes #
  • Tests added
  • Release note added (or unnecessary)

@ilan-gold ilan-gold changed the title (chore): ensure views of anndata produce view classes (chore): ensure views of anndata produce distinguishable view classes Sep 2, 2024
@ilan-gold ilan-gold added this to the 0.11.0 milestone Sep 2, 2024
@ilan-gold
Copy link
Copy Markdown
Contributor Author

ilan-gold commented Sep 2, 2024

@flying-sheep Happy to add a protocol here for having base if you think that's the way to go. I am a bit ambivalent - this solution is perhaps less robust but requires exposing less API surface area.

Without API change, can go in a patch as well

@ilan-gold ilan-gold modified the milestones: 0.11.0, 0.10.10 Sep 2, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 2, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.33%. Comparing base (2e3ab38) to head (45b5300).
⚠️ Report is 331 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1637      +/-   ##
==========================================
- Coverage   86.81%   84.33%   -2.49%     
==========================================
  Files          37       37              
  Lines        6008     6008              
==========================================
- Hits         5216     5067     -149     
- Misses        792      941     +149     
Files with missing lines Coverage Δ
src/anndata/_core/views.py 85.33% <100.00%> (-5.78%) ⬇️

... and 7 files with indirect coverage changes

@ilan-gold ilan-gold modified the milestones: 0.10.10, 0.11.1, 0.11.2 Nov 7, 2024
@flying-sheep
Copy link
Copy Markdown
Member

Hmm, good question.

I think if possible I’d prefer exporting _SetItemMixin under a different name. Maybe something containing COW (copy-on-write) to clarify semantics?

But it might not be possible to do that since python/typing#213 isn’t implemented yet. We might want to add our use case to https://github.com/CarliJoy/intersection_examples/issues

@ilan-gold ilan-gold modified the milestones: 0.11.2, 0.11.3, 0.11.4 Jan 7, 2025
@ilan-gold ilan-gold modified the milestones: 0.11.4, 0.11.5 Mar 26, 2025
@ilan-gold ilan-gold modified the milestones: 0.11.5, 0.12.1 Jul 16, 2025
@ilan-gold ilan-gold modified the milestones: 0.12.1, 0.12.2 Jul 23, 2025
@ilan-gold ilan-gold modified the milestones: 0.12.2, 0.12.3 Oct 15, 2025
@ilan-gold ilan-gold modified the milestones: 0.12.3, 0.12.4 Oct 16, 2025
@ilan-gold ilan-gold modified the milestones: 0.12.4, 0.12.5 Oct 27, 2025
@ilan-gold ilan-gold modified the milestones: 0.12.5, 0.12.7 Nov 6, 2025
@flying-sheep flying-sheep modified the milestones: 0.12.7, 0.12.8 Dec 16, 2025
@ilan-gold ilan-gold modified the milestones: 0.12.8, 0.12.9, 0.12.10 Jan 27, 2026
@ilan-gold ilan-gold modified the milestones: 0.12.10, 0.12.11 Feb 6, 2026
@ilan-gold ilan-gold modified the milestones: 0.12.11, 0.12.12 Apr 21, 2026
@ilan-gold ilan-gold modified the milestones: 0.12.12, 0.12.13, 0.12.14, 0.12.15 May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants