Skip to content

(docs): Qualname-override everything we can#1830

Merged
flying-sheep merged 2 commits into
mainfrom
pa/qualname_override_all
Jan 17, 2025
Merged

(docs): Qualname-override everything we can#1830
flying-sheep merged 2 commits into
mainfrom
pa/qualname_override_all

Conversation

@flying-sheep
Copy link
Copy Markdown
Member

@flying-sheep flying-sheep commented Jan 16, 2025

Finally no more unlinked stuff!

@flying-sheep flying-sheep changed the title Qualname-override everything we can (docs): Qualname-override everything we can Jan 16, 2025
@flying-sheep flying-sheep added this to the 0.11.4 milestone Jan 16, 2025
@Zethson
Copy link
Copy Markdown
Member

Zethson commented Jan 17, 2025

Great! Is there a big effect on the build time of the docs? I noticed in other packages that intersphinx can make things substantially slower.

In any case, I think that this is much better.

@flying-sheep
Copy link
Copy Markdown
Member Author

flying-sheep commented Jan 17, 2025

Each intersphinx inventory adds maybe 0.2 seconds to the first build.

So locally with caching, there is no difference. On RTD, there is no measurable difference:

so clearly the difference is lost in the noise.

I’ll take this as an approving review then :D

@flying-sheep flying-sheep merged commit 68bb5b4 into main Jan 17, 2025
@flying-sheep flying-sheep deleted the pa/qualname_override_all branch January 17, 2025 11:57
meeseeksmachine pushed a commit to meeseeksmachine/anndata that referenced this pull request Jan 17, 2025
flying-sheep added a commit that referenced this pull request Jan 17, 2025
Co-authored-by: Philipp A <flying-sheep@web.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants