(fix): add dask upper bound for sparse issue#1862
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1862 +/- ##
==========================================
- Coverage 86.25% 83.84% -2.42%
==========================================
Files 41 41
Lines 6288 6288
==========================================
- Hits 5424 5272 -152
- Misses 864 1016 +152 🚀 New features to boost your workflow:
|
Member
flying-sheep
left a comment
flying-sheep
left a comment
There was a problem hiding this comment.
what’s the logic for the changed bounds here?
Contributor
Author
The low bound was copy-paste miskate, the upper bound is the added issue |
flying-sheep
changed the title
flying-sheep
approved these changes
Feb 18, 2025
meeseeksmachine
pushed a commit
to meeseeksmachine/anndata
that referenced
this pull request
Feb 18, 2025
ilan-gold
added a commit
that referenced
this pull request
Feb 18, 2025
Co-authored-by: Ilan Gold <ilanbassgold@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dask/dask#11752