Backport CS* tightening#1889
Merged
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 0.11.x #1889 +/- ##
==========================================
- Coverage 86.20% 83.75% -2.46%
==========================================
Files 41 41
Lines 6250 6255 +5
==========================================
- Hits 5388 5239 -149
- Misses 862 1016 +154
🚀 New features to boost your workflow:
|
3 tasks
ilan-gold
approved these changes
Mar 6, 2025
Contributor
ilan-gold
left a comment
There was a problem hiding this comment.
Aside from the failing CI, looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So the accurate types are used in a soon-to-be-released anndata version.
I also did a few things I missed in the original review. Getting these into
mainin a separate PR: #1890TODO:
should one fix be backported? (chore): adopt scientific python deprecation schedule #1768 (review)
(no, breaking change)
only changes to types and tests