Skip to content

Format TOML with taplo#1898

Merged
flying-sheep merged 1 commit into
mainfrom
pa/taplo
Mar 7, 2025
Merged

Format TOML with taplo#1898
flying-sheep merged 1 commit into
mainfrom
pa/taplo

Conversation

@flying-sheep
Copy link
Copy Markdown
Member

@flying-sheep flying-sheep commented Mar 7, 2025

Huh, why is that not a thing? Should have been part of #1864

@flying-sheep flying-sheep requested a review from ilan-gold March 7, 2025 12:51
@flying-sheep flying-sheep added this to the 0.11.4 milestone Mar 7, 2025
Comment thread .taplo.toml
@@ -0,0 +1,5 @@
[formatting]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why put this toml under a . prefix?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think both taplo.toml and .taplo.toml work, but hiding it in file managers makes things a little cleaner. code editors will still display it.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, this would happen: tamasfe/taplo#603

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.83%. Comparing base (9a0b981) to head (617a4d0).
Report is 57 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1898      +/-   ##
==========================================
- Coverage   86.22%   83.83%   -2.40%     
==========================================
  Files          40       40              
  Lines        6347     6347              
==========================================
- Hits         5473     5321     -152     
- Misses        874     1026     +152     

see 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants