Switch to (testing.)fast-array-utils#1921
Draft
flying-sheep wants to merge 15 commits into
Draft
Conversation
Member
flying-sheep
commented
Mar 17, 2025
flying-sheep
commented
- Closes #
- Tests added
- Release note added (or unnecessary)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1921 +/- ##
==========================================
- Coverage 86.87% 84.74% -2.14%
==========================================
Files 47 47
Lines 6912 6759 -153
==========================================
- Hits 6005 5728 -277
- Misses 907 1031 +124
|
flying-sheep
changed the title
ilan-gold
reviewed
Apr 1, 2025
Contributor
ilan-gold
left a comment
ilan-gold
left a comment
There was a problem hiding this comment.
In general the amount of
@pytest.mark.array_type(skip=Flags.Gpu | Flags.Disk)
is a lot (both this one specifically, and others like it). It seems like there is probably some sort of default we could have, no?
|
|
||
|
|
||
| @pytest.fixture(scope="session") | ||
| @pytest.fixture |
Contributor
There was a problem hiding this comment.
This might be a source of some slowdown
|
|
||
|
|
||
| @pytest.fixture(scope="session") | ||
| @pytest.fixture |
| @IGNORE_SPARSE_EFFICIENCY_WARNING | ||
| def test_set_scalar_subset_X(matrix_type, subset_func): | ||
| adata = ad.AnnData(matrix_type(np.zeros((10, 10)))) | ||
| @pytest.mark.array_type(skip={Flags.Disk, *CUPY_SPARSE, *DASK_SPARRAY}) |
Contributor
There was a problem hiding this comment.
I think this sort of thing will now run these tests on gpu whereas they did not before?
| def test_not_set_subset_X_dask(matrix_type_no_gpu, subset_func): | ||
| adata = ad.AnnData(matrix_type_no_gpu(asarray(sparse.random(20, 20)))) | ||
| @pytest.mark.array_type(skip=Flags.Gpu | Flags.Disk) | ||
| def test_not_set_subset_X_dask(array_type: ArrayType, subset_func) -> None: |
Contributor
There was a problem hiding this comment.
In this case, this runs on sparse etc. as well, no?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.