Skip to content

(fix): force dask cluster tests to be run in same process#1932

Merged
ilan-gold merged 3 commits into
mainfrom
ig/run_cluster_tests_same_process
Mar 25, 2025
Merged

(fix): force dask cluster tests to be run in same process#1932
ilan-gold merged 3 commits into
mainfrom
ig/run_cluster_tests_same_process

Conversation

@ilan-gold
Copy link
Copy Markdown
Contributor

I was surprised to discover that simply making the cluster a param works, now let's see about CI

  • Closes #
  • Tests added
  • Release note added (or unnecessary)

@ilan-gold ilan-gold added this to the 0.11.4 milestone Mar 22, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.40%. Comparing base (a4d707d) to head (ced9c01).
Report is 45 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1932      +/-   ##
==========================================
- Coverage   86.51%   84.40%   -2.11%     
==========================================
  Files          45       45              
  Lines        6798     6798              
==========================================
- Hits         5881     5738     -143     
- Misses        917     1060     +143     

see 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ilan-gold ilan-gold force-pushed the ig/run_cluster_tests_same_process branch from a4a6546 to 92b1fdf Compare March 22, 2025 13:21
@ilan-gold ilan-gold changed the title (fix): use dask cluster as a session param (fix): force dask cluster tests to be run in same process Mar 22, 2025
@ilan-gold ilan-gold enabled auto-merge (squash) March 25, 2025 09:51
@ilan-gold ilan-gold merged commit eea9002 into main Mar 25, 2025
@ilan-gold ilan-gold deleted the ig/run_cluster_tests_same_process branch March 25, 2025 10:05
@lumberbot-app
Copy link
Copy Markdown

lumberbot-app Bot commented Mar 25, 2025

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 0.11.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 eea9002efaad04f5a2dfd63955f7d91c31b793c8
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #1932: (fix): force `dask` cluster tests to be run in same process'
  1. Push to a named branch:
git push YOURFORK 0.11.x:auto-backport-of-pr-1932-on-0.11.x
  1. Create a PR against branch 0.11.x, I would have named this PR:

"Backport PR #1932 on branch 0.11.x ((fix): force dask cluster tests to be run in same process)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant