(fix): scipy 1.16rc comparison issue#1999
Conversation
ilan-gold
commented
May 28, 2025
- See https://github.com/scverse/anndata/actions/runs/15297324203/job/43029456018?pr=1998 and the mentioned issue in the TODO
- Tests added (not necessary, fixing old behavior)
- Release note added (or unnecessary)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1999 +/- ##
==========================================
- Coverage 87.11% 85.06% -2.06%
==========================================
Files 46 46
Lines 6947 6949 +2
==========================================
- Hits 6052 5911 -141
- Misses 895 1038 +143
|
|
@flying-sheep We don't run coverage for pre-release. Probably best to wrap up fixing that in the hatch PR, no? |
|
yeah, we do that in scanpy, idk why we wouldn‘t do it here. |
|
Ok @flying-sheep I will merge and update the hatch PR then to ensure it has this if it does not already |
|
Looks to be covered there: https://github.com/scverse/anndata/pull/1998/files#diff-e0764e908fb46921ba065860ed59c4bf6fd95e197602f7fbf42c84579c582892R39-R48 We run pre and min under coverage, so that would cover this case |
|
@meeseeksdev backport to 1.11.x |
|
Something went wrong ... Please have a look at my logs. It seems that the branch you are trying to backport to does not exist. |
|
@meeseeksdev backport to 1.11.x |
|
Something went wrong ... Please have a look at my logs. It seems that the branch you are trying to backport to does not exist. |
|
@meeseeksdev backport to 0.11.x |
Co-authored-by: Ilan Gold <ilanbassgold@gmail.com>