Skip to content

(fix): scipy 1.16rc comparison issue#1999

Merged
ilan-gold merged 1 commit into
mainfrom
ig/scipy_fix
May 28, 2025
Merged

(fix): scipy 1.16rc comparison issue#1999
ilan-gold merged 1 commit into
mainfrom
ig/scipy_fix

Conversation

@ilan-gold
Copy link
Copy Markdown
Contributor

@ilan-gold ilan-gold added this to the 0.12.0 milestone May 28, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented May 28, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 85.06%. Comparing base (fa7c3ca) to head (f0210bd).
⚠️ Report is 41 commits behind head on main.

Files with missing lines Patch % Lines
src/anndata/_core/merge.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1999      +/-   ##
==========================================
- Coverage   87.11%   85.06%   -2.06%     
==========================================
  Files          46       46              
  Lines        6947     6949       +2     
==========================================
- Hits         6052     5911     -141     
- Misses        895     1038     +143     
Files with missing lines Coverage Δ
src/anndata/_core/merge.py 84.93% <50.00%> (-9.03%) ⬇️

... and 6 files with indirect coverage changes

@ilan-gold ilan-gold requested a review from flying-sheep May 28, 2025 13:45
@ilan-gold
Copy link
Copy Markdown
Contributor Author

@flying-sheep We don't run coverage for pre-release. Probably best to wrap up fixing that in the hatch PR, no?

@flying-sheep
Copy link
Copy Markdown
Member

yeah, we do that in scanpy, idk why we wouldn‘t do it here.

@ilan-gold
Copy link
Copy Markdown
Contributor Author

Ok @flying-sheep I will merge and update the hatch PR then to ensure it has this if it does not already

@ilan-gold ilan-gold merged commit 2e9cfca into main May 28, 2025
18 of 22 checks passed
@ilan-gold ilan-gold deleted the ig/scipy_fix branch May 28, 2025 14:36
@ilan-gold
Copy link
Copy Markdown
Contributor Author

Looks to be covered there: https://github.com/scverse/anndata/pull/1998/files#diff-e0764e908fb46921ba065860ed59c4bf6fd95e197602f7fbf42c84579c582892R39-R48

We run pre and min under coverage, so that would cover this case

@ilan-gold ilan-gold modified the milestones: 0.12.0, 0.11.5 May 28, 2025
@ilan-gold
Copy link
Copy Markdown
Contributor Author

@meeseeksdev backport to 1.11.x

@lumberbot-app
Copy link
Copy Markdown

lumberbot-app Bot commented May 28, 2025

Something went wrong ... Please have a look at my logs.

It seems that the branch you are trying to backport to does not exist.

@ilan-gold ilan-gold restored the ig/scipy_fix branch May 28, 2025 14:53
@ilan-gold
Copy link
Copy Markdown
Contributor Author

@meeseeksdev backport to 1.11.x

@lumberbot-app
Copy link
Copy Markdown

lumberbot-app Bot commented May 28, 2025

Something went wrong ... Please have a look at my logs.

It seems that the branch you are trying to backport to does not exist.

@ilan-gold
Copy link
Copy Markdown
Contributor Author

@meeseeksdev backport to 0.11.x

meeseeksmachine pushed a commit to meeseeksmachine/anndata that referenced this pull request May 28, 2025
@ilan-gold ilan-gold deleted the ig/scipy_fix branch May 28, 2025 14:53
ilan-gold added a commit that referenced this pull request May 28, 2025
Co-authored-by: Ilan Gold <ilanbassgold@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants