fix: unbound dask #2053
Merged
fix: unbound dask #2053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2053 +/- ##
==========================================
- Coverage 85.69% 85.56% -0.14%
==========================================
Files 46 46
Lines 7090 7092 +2
==========================================
- Hits 6076 6068 -8
- Misses 1014 1024 +10
|
3 tasks
ilan-gold
force-pushed
the
ig/unbound_dask
branch
from
a6112f5 to
bdb3479
Compare
ilan-gold
commented
Sep 15, 2025
tests/test_dask_view_mem.py
Outdated
| # For example from dask.random we allocate 1mb | ||
| @pytest.mark.usefixtures("_alloc_cache") | ||
| @pytest.mark.limit_memory("1.5 MB") | ||
| @pytest.mark.limit_memory("1.6 MB") |
There was a problem hiding this comment.
I am not sure what happened here, but looking at the failure stack-trace, this isn't a hallucination i.e., the total bytes add up. Why this changed, I don't know, but I don't know if it is worth jumping into this rabbit hole.
flying-sheep
requested changes
Sep 16, 2025
Co-authored-by: Philipp A. <[email protected]>
flying-sheep
approved these changes
Sep 16, 2025
meeseeksmachine
pushed a commit
to meeseeksmachine/anndata
that referenced
this pull request
Sep 16, 2025
flying-sheep
pushed a commit
that referenced
this pull request
Sep 16, 2025
Co-authored-by: Ilan Gold <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by dask/dask#12026I think I need to be more careful with upper bounds...
All good now! The scipy PR I mention in the comment is important, but not something that is either core to our internal functionality or unworkable. So I think this PR is good to go1