Skip to content

Conversation

ilan-gold
Copy link
Contributor

@ilan-gold ilan-gold commented Aug 22, 2025

I'm kind of punting on knowing that the intention of changing the backing file is after writing. I'm genuinely not sure what this feature would be for other than what I am testing i.e., why would you rewrite a non-view of a backed file in its entirety?

Copy link

codecov bot commented Aug 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.57%. Comparing base (e6fbb70) to head (27f2927).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2092   +/-   ##
=======================================
  Coverage   85.57%   85.57%           
=======================================
  Files          46       46           
  Lines        7070     7070           
=======================================
  Hits         6050     6050           
  Misses       1020     1020           
Files with missing lines Coverage Δ
src/anndata/_core/anndata.py 83.07% <100.00%> (ø)

@ilan-gold ilan-gold requested a review from flying-sheep August 22, 2025 14:16
Copy link
Member

@flying-sheep flying-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes sense, only the release note text confuses me!

@ilan-gold ilan-gold enabled auto-merge (squash) August 27, 2025 11:33
@ilan-gold ilan-gold requested a review from flying-sheep August 27, 2025 12:23
@ilan-gold ilan-gold merged commit e2d7503 into main Aug 29, 2025
18 checks passed
@ilan-gold ilan-gold deleted the ig/write_view_backed branch August 29, 2025 10:16
meeseeksmachine pushed a commit to meeseeksmachine/anndata that referenced this pull request Aug 29, 2025
flying-sheep pushed a commit that referenced this pull request Aug 29, 2025
@ilan-gold ilan-gold modified the milestones: 0.12.2, 0.12.3 Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Problems saving backed anndata in chunks

2 participants