Skip to content

fix: remove mamba backend for asv#2129

Merged
ilan-gold merged 4 commits into
mainfrom
ig/fix_benchmarking
Sep 29, 2025
Merged

fix: remove mamba backend for asv#2129
ilan-gold merged 4 commits into
mainfrom
ig/fix_benchmarking

Conversation

@ilan-gold
Copy link
Copy Markdown
Contributor

@ilan-gold ilan-gold added this to the 0.12.2 milestone Sep 23, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.64%. Comparing base (e3a6376) to head (49c3148).
⚠️ Report is 54 commits behind head on main.

❌ Your project status has failed because the head coverage (66.64%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (e3a6376) and HEAD (49c3148). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (e3a6376) HEAD (49c3148)
5 2
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2129       +/-   ##
===========================================
- Coverage   84.48%   66.64%   -17.85%     
===========================================
  Files          46       46               
  Lines        7078     7078               
===========================================
- Hits         5980     4717     -1263     
- Misses       1098     2361     +1263     

see 27 files with indirect coverage changes

@ilan-gold ilan-gold mentioned this pull request Sep 23, 2025
3 tasks
@scverse-benchmark
Copy link
Copy Markdown

Benchmark changes

Change Before [e3a6376] After [49c3148] Ratio Benchmark (Parameter)
+ 9.95±0.09ms 12.5±0.3ms 1.26 dataset2d.Dataset2D.time_getitem_slice(<function Dataset2D.> (0), (-1,))
- 322±10μs 289±6μs 0.9 sparse_dataset.SparseCSRContiguousSlice.time_getitem_adata((10000, 10000), 'alternating', False)

Comparison: https://github.com/scverse/anndata/compare/e3a6376af45e01787a4253818ea0eee029e43b69..49c314890a9d081966a7b605e0cfa3dbcad15744
Last changed: Mon, 29 Sep 2025 09:49:02 +0000

More details: https://github.com/scverse/anndata/pull/2129/checks?check_run_id=51475827886

@ilan-gold ilan-gold marked this pull request as ready for review September 29, 2025 15:04
@ilan-gold ilan-gold enabled auto-merge (squash) September 29, 2025 15:05
@ilan-gold ilan-gold disabled auto-merge September 29, 2025 15:05
@ilan-gold ilan-gold merged commit e7a1941 into main Sep 29, 2025
13 of 19 checks passed
@ilan-gold ilan-gold deleted the ig/fix_benchmarking branch September 29, 2025 15:05
meeseeksmachine pushed a commit to meeseeksmachine/anndata that referenced this pull request Sep 29, 2025
flying-sheep pushed a commit that referenced this pull request Sep 29, 2025
…asv`) (#2136)

Co-authored-by: Ilan Gold <ilanbassgold@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants