Skip to content

Conversation

ilan-gold
Copy link
Contributor

@ilan-gold ilan-gold commented Sep 27, 2025

  • See added test_write_dispatched_csr_dataset for reproducer of the underlying bug - there was no io-spec in the CS{R,C}Dataset writer, and was instead appended at the end. I am not sure why this was done but it prevents creating dispatched write functions properly on sparse datasets unless you check the type of the elem @ivirshup any history to this? It's been in since Specs for all elements #554
  • Tests added
  • Release note added (or unnecessary)

Copy link

codecov bot commented Sep 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.55%. Comparing base (5080856) to head (4264c8f).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2134      +/-   ##
==========================================
- Coverage   85.70%   85.55%   -0.15%     
==========================================
  Files          46       46              
  Lines        7078     7076       -2     
==========================================
- Hits         6066     6054      -12     
- Misses       1012     1022      +10     
Files with missing lines Coverage Δ
src/anndata/_io/specs/methods.py 90.05% <100.00%> (-0.04%) ⬇️

... and 2 files with indirect coverage changes

Copy link
Member

@flying-sheep flying-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can’t think of any reason why it would be like that 🤷

@ilan-gold ilan-gold enabled auto-merge (squash) October 1, 2025 14:01
@ilan-gold ilan-gold merged commit af5f00e into main Oct 1, 2025
23 of 27 checks passed
@ilan-gold ilan-gold deleted the ig/io_spec_fix branch October 1, 2025 15:19
meeseeksmachine pushed a commit to meeseeksmachine/anndata that referenced this pull request Oct 1, 2025
ilan-gold added a commit that referenced this pull request Oct 1, 2025
@ilan-gold ilan-gold modified the milestones: 0.12.2, 0.12.3 Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants