fix: write iospec directly with sparse dataset #2134
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_write_dispatched_csr_dataset
for reproducer of the underlying bug - there was no io-spec in theCS{R,C}Dataset
writer, and was instead appended at the end. I am not sure why this was done but it prevents creating dispatched write functions properly on sparse datasets unless you check the type of theelem
@ivirshup any history to this? It's been in since Specs for all elements #554