Skip to content

chore: use scverse-misc#2387

Merged
ilan-gold merged 7 commits into
mainfrom
ig/scverse_misc
Apr 15, 2026
Merged

chore: use scverse-misc#2387
ilan-gold merged 7 commits into
mainfrom
ig/scverse_misc

Conversation

@ilan-gold
Copy link
Copy Markdown
Contributor

@ilan-gold ilan-gold commented Apr 14, 2026

  • Closes #
  • Tests added
  • Release note not necessary because: dev change

@ilan-gold ilan-gold added this to the 0.12.11 milestone Apr 14, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 14, 2026

Codecov Report

❌ Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 85.36%. Comparing base (38b8351) to head (3f36b4e).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/anndata/types.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2387      +/-   ##
==========================================
- Coverage   87.46%   85.36%   -2.10%     
==========================================
  Files          49       49              
  Lines        7753     7694      -59     
==========================================
- Hits         6781     6568     -213     
- Misses        972     1126     +154     
Files with missing lines Coverage Δ
src/anndata/_core/aligned_mapping.py 93.85% <100.00%> (-1.21%) ⬇️
src/anndata/_core/anndata.py 85.43% <100.00%> (+0.02%) ⬆️
src/anndata/_core/extensions.py 100.00% <100.00%> (+4.68%) ⬆️
src/anndata/_io/read.py 52.55% <100.00%> (+0.24%) ⬆️
src/anndata/_io/write.py 53.68% <100.00%> (+0.49%) ⬆️
src/anndata/utils.py 86.22% <ø> (-1.65%) ⬇️
src/anndata/types.py 95.00% <92.30%> (-5.00%) ⬇️

... and 7 files with indirect coverage changes

@ilan-gold ilan-gold requested a review from flying-sheep April 14, 2026 13:44
@ilan-gold ilan-gold self-assigned this Apr 14, 2026
Copy link
Copy Markdown
Member

@flying-sheep flying-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

We do have to take to keep the mission of scverse-misc focused though, it would be unfortunate if it sprawled to become an unmaintainable mess.

Miscellaneous utility code used by scverse packages

is a bit too broad.

I’ll file an issue!

flying-sheep

This comment was marked as outdated.

@ilan-gold
Copy link
Copy Markdown
Contributor Author

We do have to take to keep the mission of scverse-misc focused though, it would be unfortunate if it sprawled to become an unmaintainable mess.

Agreed I already asked that some pandas code be removed. A smell-test is that it shouldn't have dependencies like pandas unless there is an amazing reason. Super light, focused, python.

@ilan-gold ilan-gold merged commit 40e6ab1 into main Apr 15, 2026
24 checks passed
@ilan-gold ilan-gold deleted the ig/scverse_misc branch April 15, 2026 13:15
@lumberbot-app
Copy link
Copy Markdown

lumberbot-app Bot commented Apr 15, 2026

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 0.12.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 40e6ab1a4c14152955db4c8c8f6a3ff149f64625
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #2387: chore: use `scverse-misc`'
  1. Push to a named branch:
git push YOURFORK 0.12.x:auto-backport-of-pr-2387-on-0.12.x
  1. Create a PR against branch 0.12.x, I would have named this PR:

"Backport PR #2387 on branch 0.12.x (chore: use scverse-misc)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants