Skip to content

test: fix GPU tests and docs: fix WriteCallback param description#2458

Merged
flying-sheep merged 1 commit into
mainfrom
fix-gpu-tests
May 19, 2026
Merged

test: fix GPU tests and docs: fix WriteCallback param description#2458
flying-sheep merged 1 commit into
mainfrom
fix-gpu-tests

Conversation

@flying-sheep
Copy link
Copy Markdown
Member

@flying-sheep flying-sheep commented May 19, 2026

In #1707, we forgot to adapt the GPU tests, so as_cupy was called twice on X (once as adata.layers[None] and once as adata.X). Since as_cupy deliberately only handles non-cupy data, this failed.

/edit: looks like some unrelated tiny docs fix also snuck in. eh, good.

@flying-sheep flying-sheep added this to the 0.12.17 milestone May 19, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.62%. Comparing base (75e4c33) to head (0035dac).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2458      +/-   ##
==========================================
+ Coverage   85.70%   87.62%   +1.92%     
==========================================
  Files          49       49              
  Lines        7806     7806              
==========================================
+ Hits         6690     6840     +150     
+ Misses       1116      966     -150     
Files with missing lines Coverage Δ
src/anndata/_types.py 100.00% <ø> (ø)

... and 8 files with indirect coverage changes

@flying-sheep flying-sheep changed the title tests: fix GPU tests test: fix GPU tests May 19, 2026
@flying-sheep flying-sheep merged commit a0ded88 into main May 19, 2026
35 of 41 checks passed
@flying-sheep flying-sheep deleted the fix-gpu-tests branch May 19, 2026 09:59
@scverse scverse deleted a comment from lumberbot-app Bot May 19, 2026
@flying-sheep flying-sheep changed the title test: fix GPU tests test: fix GPU tests and docs: fix WriteCallback param description May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants