Merged
Conversation
Closed
Member
|
To check sure this won't cause CI problems after merging, can you start a pr on scanpy that makes the |
Member
Author
|
Done, too bad such a nice issue number is wasted on it lol scverse/scanpy#1700 |
Member
Author
|
d339903 can probably be removed, see scverse/scanpy#1702 /edit: done, the commit is unnecessary |
ivirshup
approved these changes
Mar 3, 2021
Member
ivirshup
left a comment
ivirshup
left a comment
There was a problem hiding this comment.
Just to be sure, did you not have to update the azure setup?
Member
Author
|
No need, it’s just standard pip usage (no -e) and didn’t contain If we want, we can add a build check later like scanpy has though! |
flying-sheep
added a commit
that referenced
this pull request
Mar 3, 2021
This reverts commit f8ed61f.
flying-sheep
added a commit
that referenced
this pull request
Mar 3, 2021
This reverts commit f8ed61f.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See scverse/scanpy#1527