Improve handling in conversion from Seurat
#369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lazappi
commented
Oct 14, 2025
Comment on lines
+124
to
+127
| #' - If `assay_name` is the default assay, they will be _converted_ with a | ||
| #' warning | ||
| #' - if `assay_name` is not the default assay, they will be _skipped_ with a | ||
| #' warning |
There was a problem hiding this comment.
This logic might be a bit complex, we could make it always do one of these
rcannood
reviewed
Oct 14, 2025
Comment on lines
+507
to
+511
| if (assay_name == SeuratObject::DefaultAssay(seurat_obj)) { | ||
| cli_warn(c( | ||
| "Graph {.val {graph_name}} does not have an associated assay", | ||
| "i" = "Assuming it belongs to the selected default assay ({.val {assay_name}})" | ||
| )) |
There was a problem hiding this comment.
If we are in this edge case, will it still check whether the dimensions are correct?
There was a problem hiding this comment.
Yes, because the check for that is at the conversion step. So it will still get skipped if the dimensions don't match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: Fixes #368
Description
from_Seurat()and skip if they don't match theAnnDataChecklist
Before review
Before merge
NEWS