Skip to content

Add Zarr to benchmarks#446

Merged
rcannood merged 160 commits into
develfrom
add-zarr-benchmarks
May 12, 2026
Merged

Add Zarr to benchmarks#446
rcannood merged 160 commits into
develfrom
add-zarr-benchmarks

Conversation

@lazappi
Copy link
Copy Markdown
Collaborator

@lazappi lazappi commented Apr 15, 2026

Description

Add the Zarr backend to the benchmark tests

Needs #190

Checklist

Before review

  • Update and regenerate man pages
  • Add/update tests
  • Add/update examples in vignettes
  • Pass CI checks

Before merge

  • Update NEWS
  • Bump devel version

keller-mark and others added 30 commits May 6, 2024 16:25
Simplify how obs and var names handled in ZarrAnnData
@lazappi lazappi changed the title WIP Add Zarr to benchmarks Apr 15, 2026
@lazappi lazappi marked this pull request as draft April 15, 2026 13:49
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 15, 2026

🐰 Bencher Report

Branchadd-zarr-benchmarks
Testbedubuntu-latest

⚠️ WARNING: Truncated view!

The full continuous benchmarking report exceeds the maximum length allowed on this platform.

🐰 View full continuous benchmarking report in Bencher

@rcannood
Copy link
Copy Markdown
Member

@lazappi Aside from the linting issue, is this PR ready for review?

@lazappi
Copy link
Copy Markdown
Collaborator Author

lazappi commented Apr 27, 2026

I think so, now that the main PR is merged

@lazappi lazappi marked this pull request as ready for review April 27, 2026 09:15
@Bisaloo
Copy link
Copy Markdown
Contributor

Bisaloo commented Apr 28, 2026

Out of curiosity, would I be able to observe the impact of some changes in Rarr here?

I have my own continuous benchmarking suite but anndata(R) uses zarr in a different way which made me discover more performance issues last week. So I'd be interested in keeping an eye on your benchmarks.

@Artur-man Artur-man mentioned this pull request May 10, 2026
6 tasks
@rcannood
Copy link
Copy Markdown
Member

Out of curiosity, would I be able to observe the impact of some changes in Rarr here?

Hmm.. This might not be straight forward since you'll only know the impact of the changes you made in Rarr a new release was created.

I see Rarr has touchtone set -- does this not do something similar?

@Bisaloo
Copy link
Copy Markdown
Contributor

Bisaloo commented May 11, 2026

I see Rarr has touchtone set -- does this not do something similar?

It does. But when I worked with some anndata datasets last month, I discovered some inefficiencies I didn't suspect. In particular, because my current set of benchmarks only tests single arrays, instead of a collection of arrays as in anndata.

But based on your answer, the simplest solution is maybe to add an anndata dataset to my benchmarks then.

Copy link
Copy Markdown
Member

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rcannood rcannood merged commit 897914b into devel May 12, 2026
11 checks passed
@rcannood rcannood deleted the add-zarr-benchmarks branch May 12, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants