Skip to content

Take into account Rarr structured datatype breaking change#462

Open
Bisaloo wants to merge 2 commits into
scverse:develfrom
Bisaloo:breaking-change-recarray
Open

Take into account Rarr structured datatype breaking change#462
Bisaloo wants to merge 2 commits into
scverse:develfrom
Bisaloo:breaking-change-recarray

Conversation

@Bisaloo
Copy link
Copy Markdown
Contributor

@Bisaloo Bisaloo commented May 30, 2026

Related to:

Description

This should fix the CI failures you're seeing in devel and various PR.

Checklist

Before review

  • Update and regenerate man pages
  • Add/update tests
  • Add/update examples in vignettes
  • Pass CI checks

Before merge

  • Update NEWS
  • Bump devel version

@github-actions
Copy link
Copy Markdown

🐰 Bencher Report

Branchbreaking-change-recarray
Testbedubuntu-latest

⚠️ WARNING: Truncated view!

The full continuous benchmarking report exceeds the maximum length allowed on this platform.

🚨 1 Alert

🐰 View full continuous benchmarking report in Bencher

Copy link
Copy Markdown
Collaborator

@lazappi lazappi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the release tests are still expected to fail?

@Bisaloo
Copy link
Copy Markdown
Contributor Author

Bisaloo commented Jun 4, 2026

Yes, because the breaking changes are in devel. I could add a check on the Rarr version but with Bioconductor release cycle, it won't really have any effect, since this PR also targets anndataR devel.

You'll always have odd results with a workflow running checks on anndataR devel vs Bioconductor release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants