Get test matrix from hatch#390
Conversation
|
A PR has been generated to the instance repo: You can check out the PR to preview your changes |
|
Oooh that’s sexy, I didn’t think of that! |
grst
left a comment
There was a problem hiding this comment.
Hi @flying-sheep,
there are still some issues that need to be resolved, maybe you have an idea for some of them.
Overall, I'm also still a bit hesitant if this is the way to go. The jq command is a bit obsure to someone who hasn't worked with that before, and I feel it makes it very hard for developers using the template to understand what's actually going on... whereas
- os: ubuntu-latest
python: "3.12"
- os: ubuntu-latest
python: "3.12"
pip-flags: "--pre"
name: PRE-RELEASE DEPENDENCIES
is pretty explicit.
|
AH, missed that today. I’ll take a look on monday! |
|
If we get this to work, we should probably also use https://github.com/marketplace/actions/alls-green#why |
|
So for excluding the incompatible python versions, the only thing I can think of is manually excluding them because of pypa/hatch#1571 When you run |
Together with #386, we anyway will need to manually define lower and upper python bounds in the |
This reverts commit 6135fc4.
|
Good point! I checked how it would look like to use a Python script instead, and it’s pretty OK, but this is more local. |
How big do you think the overlap is between “needs to customize the test jobs in a way that isn’t covered by editing pyproject.toml” and “doesn’t know jq”? Not a leading question, I don’t know the answer here. I think combined with https://github.com/marketplace/actions/alls-green, this PR would make it so few people need to touch this workflow, whereas with a duplicated matrix, people do have to sync them. |
No description provided.