-
Notifications
You must be signed in to change notification settings - Fork 0
Allow use on 1d arrays #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #84 +/- ##
==========================================
+ Coverage 98.91% 98.95% +0.03%
==========================================
Files 17 17
Lines 370 381 +11
==========================================
+ Hits 366 377 +11
Misses 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #84 will improve performances by ×4Comparing Summary
Benchmarks breakdown
|
if axis is None: | ||
return cast("np.number[Any]", x.data.sum(dtype=dtype)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
without this, 1D csr_array
s sum up to np.float64 no matter if bool, int, or float32.
that’s not the case for 2D ones, so I should probably report this as an issue to scipy.
One thing we could do is making the
assert_array_equal
sstrict=True
.That’d require downcasting
float64
tofloat32
in some cases though.