Skip to content

Fix Dask handling for chunks with 1-wide dimension #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 28, 2025
Merged

Conversation

flying-sheep
Copy link
Member

@flying-sheep flying-sheep commented Apr 25, 2025

TODO: find other configurations where this doesn’t work and add to test cases.

Copy link

codecov bot commented Apr 25, 2025

Codecov Report

Attention: Patch coverage is 18.18182% with 36 lines in your changes missing coverage. Please review.

Project coverage is 84.23%. Comparing base (c34cb6d) to head (5812b9d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/fast_array_utils/stats/_sum.py 16.27% 36 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (c34cb6d) and HEAD (5812b9d). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (c34cb6d) HEAD (5812b9d)
4 3
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #87       +/-   ##
===========================================
- Coverage   98.94%   84.23%   -14.71%     
===========================================
  Files          17       17               
  Lines         379      406       +27     
===========================================
- Hits          375      342       -33     
- Misses          4       64       +60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

codspeed-hq bot commented Apr 25, 2025

CodSpeed Performance Report

Merging #87 will degrade performances by 46.51%

Comparing pa/wtf-dask (5812b9d) with main (c34cb6d)

Summary

❌ 1 regressions
✅ 159 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_stats_benchmark[2d-ax1-scipy.sparse.csr_array-float64-is_constant] 750.2 µs 1,402.5 µs -46.51%

@flying-sheep flying-sheep added the run-gpu-ci Apply this label to run GPU CI once label Apr 28, 2025
@flying-sheep flying-sheep marked this pull request as ready for review April 28, 2025 11:11
@flying-sheep flying-sheep requested a review from ilan-gold April 28, 2025 11:12
@github-actions github-actions bot removed the run-gpu-ci Apply this label to run GPU CI once label Apr 28, 2025
@flying-sheep flying-sheep added the run-gpu-ci Apply this label to run GPU CI once label Apr 28, 2025
@github-actions github-actions bot removed the run-gpu-ci Apply this label to run GPU CI once label Apr 28, 2025
@flying-sheep flying-sheep requested a review from ilan-gold April 28, 2025 14:12
@flying-sheep flying-sheep added the run-gpu-ci Apply this label to run GPU CI once label Apr 28, 2025
@github-actions github-actions bot removed the run-gpu-ci Apply this label to run GPU CI once label Apr 28, 2025
@flying-sheep flying-sheep merged commit 630b0cb into main Apr 28, 2025
8 of 10 checks passed
@flying-sheep flying-sheep deleted the pa/wtf-dask branch April 28, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants