Skip to content

Work in progress: Significance threshold.#974

Draft
LuisHeinzlmeier wants to merge 2 commits into
scverse:mainfrom
LuisHeinzlmeier:feature/967-sig-threshold
Draft

Work in progress: Significance threshold.#974
LuisHeinzlmeier wants to merge 2 commits into
scverse:mainfrom
LuisHeinzlmeier:feature/967-sig-threshold

Conversation

@LuisHeinzlmeier
Copy link
Copy Markdown

PR Checklist

  • Referenced issue is linked
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Description of changes

Technical details

Additional context

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 18, 2026

Codecov Report

❌ Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.81%. Comparing base (12897e1) to head (7612986).
⚠️ Report is 60 commits behind head on main.

Files with missing lines Patch % Lines
pertpy/tools/_enrichment.py 42.85% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #974      +/-   ##
==========================================
- Coverage   73.54%   71.81%   -1.73%     
==========================================
  Files          48       48              
  Lines        5613     5737     +124     
==========================================
- Hits         4128     4120       -8     
- Misses       1485     1617     +132     
Files with missing lines Coverage Δ
...ertpy/tools/_differential_gene_expression/_base.py 90.24% <ø> (+1.21%) ⬆️
pertpy/tools/_enrichment.py 64.46% <42.85%> (-1.63%) ⬇️

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LuisHeinzlmeier
Copy link
Copy Markdown
Author

@Zethson, this is still work in progress for #967, but before I try to harmonize all threshold naming:

  • Are you happy with the names?
  • Are you happy with how I handle backward compatibility?

@Zethson
Copy link
Copy Markdown
Member

Zethson commented May 18, 2026

2x yes. But you may also introduce scverse-misc and use https://scverse-misc.readthedocs.io/stable/generated/scverse_misc.deprecated_arg.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants