Add support for isolated vertices in kNN graph for clustering #476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `_create_graph`, pass vertex list to `from_cudf_edgelist` to avoid error when adjacency matrix contains isolated vertices.
|
@jpintar Im on PTO atm. Ill be back on the 20th |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the definition of
_create_graph, pass vertex list (i.e.list(range(adjacency.shape[0]))) tofrom_cudf_edgelistvia theverticeskeyword to avoid an error when trying to perform clustering on an adjacency matrix that contains isolated vertices. This matches support for isolated vertices in the Scanpyigraph-based implementation, where the definition ofget_igraph_from_adjacencycontains:I did not add any tests, since there will be no impact when used with default (i.e. UMAP-weighted) connectivities, which do not contain any isolated vertices.
Closes #474.