chore: upstream cigar#57
Merged
Merged
Conversation
Collaborator
|
Oh yea so funny story. |
Member
Author
|
So you’re saying that we should get rid of |
Collaborator
|
I'm saying we should fix it. |
Member
Author
|
Is that a yes? Otherwise I don’t know what “fix” means, as I don’t know of anything that’s broken, just duplicate code that we can eliminate. |
flying-sheep
commented
May 15, 2026
flying-sheep
commented
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: why are we rolling our own
CigarOpinstead of usingnoodles::sam::alignment::record::cigar::Op?The only difference seems to be that that one has a
Padvariant that we don’t have.