-
Notifications
You must be signed in to change notification settings - Fork 117
(feat): match pbmc3k tutorial to seurat's #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
776f7f5
to
7629596
Compare
@flying-sheep Still very rough, but looking for some feedback given the above "outstanding" issues, especially on framing the reproducibility aspect |
Blast from the past: I also use an ARPACKy PCA in If nothing changed in the space, that might be their way forward as well, but of course I don’t know if RSpectra’s PCA is 100% identical to ARPACK. |
View / edit / reply to this conversation on ReviewNB flying-sheep commented on 2025-05-15T15:26:26Z there seems to be no output from |
View / edit / reply to this conversation on ReviewNB flying-sheep commented on 2025-05-15T15:26:27Z I don’t really get what “up to ties” means |
View / edit / reply to this conversation on ReviewNB flying-sheep commented on 2025-05-15T15:26:28Z Line #2. adata_subset_hvg = adata[:, adata.var["highly_variable"]].copy()
hmm, maybe explain that you’re using that subset for a while until you go back to the non-subset one?
I think it’s maybe a bit confusing that there are two |
View / edit / reply to this conversation on ReviewNB flying-sheep commented on 2025-05-15T15:26:28Z We should just switch to
|
TODO:
arpack
since an R implementation exists: https://search.r-project.org/CRAN/refmans/igraph/html/arpack.html andigraph
is available in R: https://igraph.org/r/doc/cluster_leiden.htmlrendered