Skip to content

Allow users to pass inner to sc.pl.violin when multi_panel=True#2083

Draft
ivirshup wants to merge 1 commit into
scverse:mainfrom
ivirshup:violin-inner-kwarg
Draft

Allow users to pass inner to sc.pl.violin when multi_panel=True#2083
ivirshup wants to merge 1 commit into
scverse:mainfrom
ivirshup:violin-inner-kwarg

Conversation

@ivirshup
Copy link
Copy Markdown
Member

Might fix my proposed solution for #2051

@WeilerP, do you remember why you explicitly set inner=None here in #1422?

@ivirshup ivirshup added this to the 1.8.3 milestone Dec 14, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 14, 2021

Codecov Report

Merging #2083 (da2d5dd) into master (58f4904) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2083      +/-   ##
==========================================
- Coverage   71.21%   71.20%   -0.02%     
==========================================
  Files          92       92              
  Lines       11248    11250       +2     
==========================================
  Hits         8010     8010              
- Misses       3238     3240       +2     
Impacted Files Coverage Δ
scanpy/plotting/_anndata.py 85.34% <ø> (ø)
scanpy/tools/_louvain.py 20.21% <0.00%> (-0.44%) ⬇️

@WeilerP
Copy link
Copy Markdown
Contributor

WeilerP commented Dec 14, 2021

Hm, no, sorry not entirely sure. I guess it was to mimic the behavior here. In the original implementation, kwds wasn't passed to the stripplot function (see here) but it was in #1422. From briefly skimming the docs here I believe inner and cut aren't valid arguments.

@ivirshup ivirshup modified the milestones: 1.8.3, 1.9.0 Mar 21, 2022
@ivirshup ivirshup modified the milestones: 1.9.0, 1.10.0 Apr 1, 2022
@ivirshup ivirshup modified the milestones: 1.10.0, 1.11.0 Feb 20, 2024
@flying-sheep flying-sheep modified the milestones: 1.11.0, 1.12.0 Dec 20, 2024
@flying-sheep flying-sheep modified the milestones: 1.12.0, 1.13.0 Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants