Catch all warnings#3724
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3724 +/- ##
==========================================
- Coverage 76.02% 75.96% -0.06%
==========================================
Files 117 117
Lines 12546 12549 +3
==========================================
- Hits 9538 9533 -5
- Misses 3008 3016 +8
|
flying-sheep
commented
Jul 22, 2025
flying-sheep
commented
Jul 22, 2025
flying-sheep
commented
Jul 22, 2025
flying-sheep
commented
Jul 22, 2025
flying-sheep
commented
Jul 22, 2025
flying-sheep
commented
Jul 22, 2025
flying-sheep
commented
Jul 22, 2025
ilan-gold
reviewed
Jul 22, 2025
Contributor
There was a problem hiding this comment.
I need to make another pass at this to be sure I understand what is going on. Here's my understanding, this PR seems to do a few things:
- Remove all warnings in
pyproject.tomlthat don't apply anymore (presumably?) - Catch all warnings explicitly that weren't caught before (I can see this locally)
- Clean up some
anndata<0.9straggling functions/compat
Is this right?
I still get locally SparseEfficiencyWarning and NumbaPerformanceWarning. Do you see this as well?
flying-sheep
commented
Jul 22, 2025
ilan-gold
reviewed
Jul 22, 2025
ilan-gold
reviewed
Jul 23, 2025
ilan-gold
approved these changes
Jul 23, 2025
Nismamjad1
pushed a commit
to Nismamjad1/scanpy-yomix
that referenced
this pull request
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO:
scanpy/tests/test_highly_variable_genes.py
Lines 698 to 702 in 02ecd49