Skip to content

Catch all warnings#3724

Merged
flying-sheep merged 38 commits into
mainfrom
pa/fix-warnings
Jul 23, 2025
Merged

Catch all warnings#3724
flying-sheep merged 38 commits into
mainfrom
pa/fix-warnings

Conversation

@flying-sheep
Copy link
Copy Markdown
Member

@flying-sheep flying-sheep commented Jul 21, 2025

  • Release notes not necessary because:

TODO:

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 21, 2025

Codecov Report

❌ Patch coverage is 84.50704% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.96%. Comparing base (0b82c93) to head (4b6ec91).
⚠️ Report is 45 commits behind head on main.

Files with missing lines Patch % Lines
src/scanpy/tools/_leiden.py 20.00% 4 Missing ⚠️
src/scanpy/tools/_tsne.py 0.00% 3 Missing ⚠️
src/scanpy/tools/_sim.py 92.30% 2 Missing ⚠️
src/scanpy/_utils/__init__.py 66.66% 1 Missing ⚠️
src/scanpy/readwrite.py 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3724      +/-   ##
==========================================
- Coverage   76.02%   75.96%   -0.06%     
==========================================
  Files         117      117              
  Lines       12546    12549       +3     
==========================================
- Hits         9538     9533       -5     
- Misses       3008     3016       +8     
Files with missing lines Coverage Δ
src/scanpy/datasets/_datasets.py 100.00% <100.00%> (ø)
src/scanpy/datasets/_utils.py 100.00% <ø> (ø)
src/scanpy/logging.py 97.34% <100.00%> (+0.02%) ⬆️
src/scanpy/plotting/_tools/__init__.py 75.88% <100.00%> (ø)
src/scanpy/plotting/_tools/paga.py 66.60% <100.00%> (-0.19%) ⬇️
src/scanpy/plotting/_tools/scatterplots.py 83.01% <100.00%> (-0.04%) ⬇️
src/scanpy/preprocessing/_highly_variable_genes.py 93.72% <100.00%> (+0.02%) ⬆️
src/scanpy/preprocessing/_pca/__init__.py 88.77% <ø> (+0.33%) ⬆️
src/scanpy/preprocessing/_simple.py 90.69% <ø> (ø)
src/scanpy/tools/_ingest.py 75.54% <ø> (ø)
... and 7 more

... and 1 file with indirect coverage changes

@flying-sheep flying-sheep marked this pull request as ready for review July 22, 2025 07:44
Comment thread src/scanpy/plotting/_tools/paga.py
Comment thread src/scanpy/preprocessing/_simple.py
Comment thread src/testing/scanpy/_pytest/fixtures/__init__.py Outdated
Comment thread tests/test_highly_variable_genes.py
Comment thread tests/test_preprocessing.py
Comment thread tests/test_rank_genes_groups.py
Comment thread tests/test_scaling.py
@flying-sheep flying-sheep requested a review from ilan-gold July 22, 2025 08:12
@flying-sheep flying-sheep added this to the 1.12.0 milestone Jul 22, 2025
Copy link
Copy Markdown
Contributor

@ilan-gold ilan-gold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to make another pass at this to be sure I understand what is going on. Here's my understanding, this PR seems to do a few things:

  1. Remove all warnings in pyproject.toml that don't apply anymore (presumably?)
  2. Catch all warnings explicitly that weren't caught before (I can see this locally)
  3. Clean up some anndata<0.9 straggling functions/compat

Is this right?

I still get locally SparseEfficiencyWarning and NumbaPerformanceWarning. Do you see this as well?

Comment thread src/scanpy/datasets/_datasets.py
Comment thread src/testing/scanpy/_pytest/fixtures/__init__.py
@flying-sheep flying-sheep requested a review from ilan-gold July 22, 2025 11:05
Comment thread src/scanpy/datasets/_datasets.py
Comment thread pyproject.toml Outdated
Comment thread tests/test_qc_metrics.py Outdated
Comment thread tests/test_highly_variable_genes.py
Comment thread tests/test_get.py Outdated
Comment thread src/scanpy/readwrite.py
@flying-sheep flying-sheep requested a review from ilan-gold July 22, 2025 16:56
Comment thread tests/test_get.py
Comment thread src/scanpy/tools/_tsne.py
Comment thread tests/test_highly_variable_genes.py
@flying-sheep flying-sheep requested a review from ilan-gold July 23, 2025 12:20
@flying-sheep flying-sheep merged commit 93b8c4b into main Jul 23, 2025
14 checks passed
@flying-sheep flying-sheep deleted the pa/fix-warnings branch July 23, 2025 14:49
Nismamjad1 pushed a commit to Nismamjad1/scanpy-yomix that referenced this pull request Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scanpy’s tests should prevent DeprecationWarnings and FutureWarnings

2 participants