-
Notifications
You must be signed in to change notification settings - Fork 742
feat: add dotplot variant #3890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
3fafabc
Add dogplot
VladimirShitov f340331
Add a test for dogplot
VladimirShitov 544f3aa
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 06267ff
Change image format to webp, reduce size
VladimirShitov 55715db
Change image format to webp, reduce size
VladimirShitov c2e0720
Use importlib to access images
VladimirShitov 92def3c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 35def5d
Fix docstring to match code style
VladimirShitov 54703b3
only use declared imports
flying-sheep 76f0cc0
best practice lol
flying-sheep 55f7d71
oops
flying-sheep File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| from __future__ import annotations | ||
|
|
||
| from pathlib import Path | ||
|
|
||
| import matplotlib.pyplot as plt | ||
| import numpy as np | ||
|
|
||
| HERE = Path(__file__).parent | ||
|
|
||
|
|
||
| def dogplot(*_, **__) -> None: | ||
| """Shows who's a good boy""" | ||
| pic = np.random.randint(1, 4) | ||
| pic_path = HERE / "dogplot_images" / f"doggo_{pic}.jpg" | ||
|
|
||
| img = plt.imread(pic_path) | ||
| plt.imshow(img) | ||
| plt.axis("off") | ||
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use
importlib.resourcesinstead, something like:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Did it, using
importlib.resources.filesthough