Skip to content

Conversation

ori-kron-wis
Copy link
Collaborator

@ori-kron-wis ori-kron-wis commented Oct 19, 2025

The idea here is to simulate the case where scvi-tools is being installed w/o jax, as it is starting 1.4.0, and then check all the tests, making sure everything works (beside the JAX-related tests)

@ori-kron-wis ori-kron-wis self-assigned this Oct 19, 2025
@ori-kron-wis ori-kron-wis added jax autotune cuda tests Run test suite on CUDA private tests Run private tests custom_dataloader PR 2932 optional tests Run optional tests internet tests Run internet tests cuda optional tests multiGPU tests Run test suite on Multi GPU CUDA workstation nonJAX and removed jax autotune cuda tests Run test suite on CUDA custom_dataloader PR 2932 optional tests Run optional tests internet tests Run internet tests multiGPU tests Run test suite on Multi GPU CUDA workstation cuda optional tests private tests Run private tests labels Oct 19, 2025
@ori-kron-wis ori-kron-wis added the on-merge: backport to 1.4.x on-merge: backport to 1.4.x label Oct 19, 2025
Copy link

codecov bot commented Oct 19, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.15%. Comparing base (6fc1538) to head (14b6ddc).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/scvi/distributions/_negative_binomial.py 80.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (6fc1538) and HEAD (14b6ddc). Click for more details.

HEAD has 63 uploads less than BASE
Flag BASE (6fc1538) HEAD (14b6ddc)
67 4
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3558       +/-   ##
===========================================
- Coverage   87.30%   74.15%   -13.15%     
===========================================
  Files         224      224               
  Lines       21011    21013        +2     
===========================================
- Hits        18344    15583     -2761     
- Misses       2667     5430     +2763     
Files with missing lines Coverage Δ
src/scvi/distributions/_negative_binomial.py 83.39% <80.00%> (-1.07%) ⬇️

... and 61 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ori-kron-wis ori-kron-wis merged commit 1cc03d1 into main Oct 19, 2025
19 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/scvi-tools that referenced this pull request Oct 19, 2025
ori-kron-wis added a commit that referenced this pull request Oct 19, 2025
#3559)

Backport PR #3558: test: removing jax from test-suite

Co-authored-by: Ori Kronfeld <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

nonJAX on-merge: backport to 1.4.x on-merge: backport to 1.4.x

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant