Skip to content

feat: add shared memory for DDP data deduplication#3754

Draft
ori-kron-wis wants to merge 8 commits into
mainfrom
Ori-reduce-DPP-memory-footprint
Draft

feat: add shared memory for DDP data deduplication#3754
ori-kron-wis wants to merge 8 commits into
mainfrom
Ori-reduce-DPP-memory-footprint

Conversation

@ori-kron-wis
Copy link
Copy Markdown
Collaborator

No description provided.

@ori-kron-wis ori-kron-wis self-assigned this Mar 19, 2026
@ori-kron-wis ori-kron-wis added the on-merge: backport to 1.4.x on-merge: backport to 1.4.x label Mar 19, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 19, 2026

Codecov Report

❌ Patch coverage is 45.40230% with 95 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.17%. Comparing base (5dacc67) to head (9e2e551).

Files with missing lines Patch % Lines
src/scvi/dataloaders/_shared_memory.py 45.65% 75 Missing ⚠️
src/scvi/dataloaders/_data_splitting.py 56.52% 10 Missing ⚠️
src/scvi/train/_trainrunner.py 23.07% 10 Missing ⚠️

❌ Your patch check has failed because the patch coverage (45.40%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3754      +/-   ##
==========================================
- Coverage   88.53%   88.17%   -0.36%     
==========================================
  Files         237      238       +1     
  Lines       23827    24001     +174     
==========================================
+ Hits        21095    21164      +69     
- Misses       2732     2837     +105     
Flag Coverage Δ
integration 72.41% <45.40%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/scvi/dataloaders/_data_splitting.py 92.93% <56.52%> (-3.41%) ⬇️
src/scvi/train/_trainrunner.py 76.25% <23.07%> (-5.49%) ⬇️
src/scvi/dataloaders/_shared_memory.py 45.65% <45.65%> (ø)

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ori-kron-wis ori-kron-wis added the multiGPU tests Run test suite on Multi GPU CUDA workstation label Mar 19, 2026
@ori-kron-wis ori-kron-wis removed the multiGPU tests Run test suite on Multi GPU CUDA workstation label May 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

on-merge: backport to 1.4.x on-merge: backport to 1.4.x

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant