Skip to content

feat: Add RESOLVI graph dataloader integration and benchmark CI#3798

Draft
ori-kron-wis wants to merge 2 commits into
mainfrom
Ori-graph-dataloader
Draft

feat: Add RESOLVI graph dataloader integration and benchmark CI#3798
ori-kron-wis wants to merge 2 commits into
mainfrom
Ori-graph-dataloader

Conversation

@ori-kron-wis
Copy link
Copy Markdown
Collaborator

No description provided.

@ori-kron-wis ori-kron-wis self-assigned this May 5, 2026
@ori-kron-wis ori-kron-wis added the on-merge: backport to 1.4.x on-merge: backport to 1.4.x label May 5, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

❌ Patch coverage is 94.73684% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.27%. Comparing base (612157b) to head (a80e39a).

Files with missing lines Patch % Lines
src/scvi/dataloaders/_graph_dataloader.py 94.52% 4 Missing ⚠️
src/scvi/external/resolvi/_module.py 93.87% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3798      +/-   ##
==========================================
+ Coverage   88.23%   88.27%   +0.03%     
==========================================
  Files         229      230       +1     
  Lines       22646    22773     +127     
==========================================
+ Hits        19981    20102     +121     
- Misses       2665     2671       +6     
Flag Coverage Δ
integration 71.61% <94.73%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/scvi/dataloaders/__init__.py 100.00% <100.00%> (ø)
src/scvi/external/resolvi/_model.py 96.00% <100.00%> (+0.21%) ⬆️
src/scvi/external/resolvi/_module.py 95.41% <93.87%> (+<0.01%) ⬆️
src/scvi/dataloaders/_graph_dataloader.py 94.52% <94.52%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

self.edge_obsm_keys = edge_obsm_keys
self.load_neighbor_expression = load_neighbor_expression
if load_neighbor_expression:
self._full_dataset = AnnTorchDataset(
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You still use this construct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

on-merge: backport to 1.4.x on-merge: backport to 1.4.x

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants