Support collecting editable distributions #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ilan-gold
approved these changes
Jul 24, 2025
| from __future__ import annotations | ||
|
|
||
| import re | ||
| from importlib.metadata import Distribution, distributions |
There was a problem hiding this comment.
Are there docs for this distributions function https://docs.python.org/3/library/importlib.metadata.html? Presumably it gets all packages in the current env or?
There was a problem hiding this comment.
Huh, right. I’m pretty sure it’s safe given that it’s in __all__ and therefore meant to be exported: python/cpython#110937
There was a problem hiding this comment.
Yup, @jaraco said so: python/importlib_metadata#494 (comment)
|
|
||
| def _top_level_editable(dist: Distribution) -> Generator[str, None, None]: | ||
| """Find top-level packages in an editable distribution.""" | ||
| for pth_file in dist.files or (): |
There was a problem hiding this comment.
Not sure I follow what is in files given https://docs.python.org/3/library/importlib.metadata.html#importlib.metadata.Distribution. It's just all the files in the package or?
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #63
I just tested it on my scanpy dev environment, and it works!
>>> import scanpy, anndata; scanpy.logging.print_header() scanpy 1.12.0.dev128+g6bfc3323.d20250616 (1.12.0.dev93+gaef3e9e1.d20250724) anndata 0.11.4 ---- ---- asttokens 3.0.0 matplotlib 3.10.3 scikit-learn 1.7.0 …