Skip to content

Don’t render JSON by default and add min tests #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Dec 17, 2024
Merged

Don’t render JSON by default and add min tests #81

merged 12 commits into from
Dec 17, 2024

Conversation

flying-sheep
Copy link
Member

@flying-sheep flying-sheep commented Dec 16, 2024 •
edited
Loading

This checks that there is an error message in case ipywidgets is not instealled. Currently, this is just the traceback of the ModuleNotFoundError: No module named 'ipywidgets'.

@Intron7 how do you suggest we improve that?

@flying-sheep flying-sheep mentioned this pull request Dec 16, 2024
Merged
3 tasks
@flying-sheep flying-sheep marked this pull request as draft December 16, 2024 13:37
@flying-sheep flying-sheep marked this pull request as ready for review December 16, 2024 15:49
@flying-sheep flying-sheep requested a review from Intron7 December 16, 2024 16:12
@flying-sheep flying-sheep changed the title Min tests Don’t render JSON by default and add min tests Dec 17, 2024
Intron7
Intron7 reviewed Dec 17, 2024
View reviewed changes
Copy link
Member

@Intron7 Intron7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love if this wouldnt error but throw a warning about ipywidget other than that I'm happy with the changes and generally approve

@flying-sheep flying-sheep requested a review from Intron7 December 17, 2024 11:19
@flying-sheep
Copy link
Member Author

OK Done!
image

@flying-sheep flying-sheep merged commit c7ae6f1 into main Dec 17, 2024
5 checks passed
@flying-sheep flying-sheep deleted the pa/test-min branch December 17, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Intron7 Intron7 Intron7 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@flying-sheep @Intron7