Add type hint when get a SpatialElement item#939
Merged
LucaMarconato merged 3 commits intoscverse:mainfrom May 25, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #939 +/- ##
=======================================
Coverage 92.11% 92.11%
=======================================
Files 48 48
Lines 7429 7432 +3
=======================================
+ Hits 6843 6846 +3
Misses 586 586
🚀 New features to boost your workflow:
|
Member
|
LGTM thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when we get an item by name, e.g.
geo_df = sdata.shapes["boundaries"], then the type ofgeo_dfis not inferred and we lose type hints and auto-completion.This PR aims to fix this, via the use of
TypeVar, to precise the type of each element.I also added
AnnDatato the return types ofSpatialData.__getitem__