javascript: use persistent http connections #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deejayem
force-pushed
the
javascript-fix-https
branch
from
3c93440 to
c0db88a
Compare
Collaborator
|
@deejayem , can you please rebase |
Contributor
Author
@dkropachev sure. It looks as though your latest changes already solve two of the issues, but I can update this PR to just use persistent connections. |
deejayem
force-pushed
the
javascript-fix-https
branch
from
c0db88a to
17f9dc2
Compare
deejayem
changed the title
Contributor
Author
|
@dkropachev how does it look now? I think we can already close #143 with your changes. |
dkropachev
approved these changes
Sep 30, 2025
Collaborator
|
@deejayem , thanks David for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #143, Alternator.js is currently broken for https endpoints for a couple of reasons, namely a hard-coded port number, and using the wrong agent object (
http.Agent, instead ofhttps.Agent).This PR has three commits: one to fix each of those two issues, and one to use persistent http connections (passing
{ keepAlive: true }to the agent). To set the agent ininit, I had to move some other code into there as well, otherwise it runs before agent is initialised.With regards to the agent options, I would recommend also allowing the caller of
initto pass their own options in (and then merge the two objects), but I didn't want to include too much in one PR.I'm happy to squash, revert, or edit any parts of this (or to extend it with my extra options suggestion).