fix(driver_matrix_test.cli): add missing extra_headers arguments #631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
and we'll need a new client version for this one. |
soyacz
approved these changes
Mar 28, 2025
can you bump also version in this PR then? |
in the finish-run command the `extra_headers` argumnet was missing while it was define as click option, and when it would be passed to the function it would fail this introduce the argument, and pass it to the ArgusClient
fruch
force-pushed
the
fix_extra_headers_v2
branch
from
6953d72 to
71725f6
Compare
now I did |
ugh, I didn't check and merged - you didn't 😅 |
|
bumped and pushed to PyPi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in the finish-run command the
extra_headersargumnet was missing while it was define as click option, and when it would be passed to the function it would failthis introduce the argument, and pass it to the ArgusClient