improvement(TestRun): allow linking to secific tab#638
Merged
soyacz merged 1 commit intoscylladb:masterfrom Apr 18, 2025
Merged
improvement(TestRun): allow linking to secific tab#638soyacz merged 1 commit intoscylladb:masterfrom
soyacz merged 1 commit intoscylladb:masterfrom
Conversation
There was a problem hiding this comment.
Copilot reviewed 3 out of 7 changed files in this pull request and generated no comments.
Files not reviewed (4)
- frontend/TestRun/TestRun.svelte: Language not supported
- frontend/WorkArea/TestRunDispatcher.svelte: Language not supported
- frontend/WorkArea/TestRuns.svelte: Language not supported
- templates/run_view_by_plugin.html.j2: Language not supported
Added possibility to link to specific tab in TestRun view. closes: scylladb#604
soyacz
force-pushed
the
604-link-to-specific-tab
branch
from
a0386b9 to
2220b24
Compare
k0machi
requested changes
Apr 18, 2025
Collaborator
k0machi
left a comment
k0machi
left a comment
There was a problem hiding this comment.
Overall looks good, aside from a minor change to how we handle navigation between tabs
k0machi
approved these changes
Apr 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added possibility to link to specific tab in TestRun view.
closes: #604