<framer> optimization readHeader(...)#428
Closed
illia-li wants to merge 1 commit intoscylladb:masterfrom
Closed
Conversation
Makes different functions for different protocol versions
Collaborator
|
Don't worth it. |
mykaul
reviewed
Apr 14, 2025
| if err != nil { | ||
| return frameHeader{}, err | ||
| func readHeader(connProto byte, r io.Reader, p []byte) (head frameHeader, err error) { | ||
| if connProto == 2 { |
Author
There was a problem hiding this comment.
There are people who find it very difficult to let go of something old, and there are also people who help them with this.
There was a problem hiding this comment.
That's OK - but those people can (and maybe should!) stay with older drivers as well, as this is not a tested code path, most likely.
|
@illia-li - perhaps those should be either measured and/or shown to reduce code size/bloat? |
Author
That's a great suggestion. I'll do that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes different functions for different protocol versions