[#527] Implement SCYLLA_USE_METADATA_ID protocol extention negotiat…
#590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@nikagra , please rebase and update PR description |
Native Protocol 5 was introduced with the release of C* 4.0. This PR provides full support for a newer version including new format frames (segments), and new fields for QUERY, BATCH, and EXECUTE messages. Also, this PR brings changes to the Compressor interface to follow an append-like design. One more thing, it bumps Go version to the newer 1.19. Patch by Bohdan Siryk; Reviewed by João Reis, James Hartig for CASSGO-1 CASSGO-30
…y to internal package. Integration tests config changes. Reverting unwanted merge changes.
Detailed summary:
- Moving CRC functionality to internal package.
- Update test cluster hosts to match CCM-created cluster
- Update flagCluster default from 127.0.0.1 to 127.0.2.1,127.0.2.2,127.0.2.3 to align with the 3-node cluster configuration created by CCM. Fixes connection refused errors in integration tests.
- Adding validation to `ReadTimeout` value in `ClusterConfig`
- Removing `headSize` from `framer`.
- Adding `.vscode` to `.gitignore`.
nikagra
force-pushed
the
support-scylla-use-metadata-id-extention
branch
from
eab9ebd to
6ce9936
Compare
…nhancements. Refactor keyspace handling in `TestQuery_SetKeyspace`
Changes: - Implemented `scyllaUseMetadataIdExt` as `cqlProtocolExtension` interface (ensures protocol extension negotiation) - Updated `framer` to have `scyllaUseMetadataId` flag set if the extension was negotiated - Use `scyllaUseMetadataId` flag to: - write `resultMetadataID` during writing of EXECUTE frame and - read `resultMetadataID` during parsing of RESULT (prepared) frame
nikagra
force-pushed
the
support-scylla-use-metadata-id-extention
branch
from
a56f941 to
c3fb900
Compare
…lla's metadata ID extension with comprehensive test cases for various protocol versions.
nikagra
force-pushed
the
support-scylla-use-metadata-id-extention
branch
from
1f2fe11 to
4999fb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ion.
Issue gocql#527
Prepared statements invalidation used to be completely broken, you can read details on it here
Recently core merged PR that fixes problems for select statements.
After that PR, if driver supply
SCYLLA_USE_METADATA_IDat the startup, when statements is prepared server hands out result queries metadata hash.When driver executes this query it sends metadata id alongside with the request.
Server checks driver metadata id and what it has on its side, if there is any difference it will send new metadata and metadata id.
Driver suppose to pick it up and update metadata and metadata id on it's side, before deserializing response, solving issue with having outdated metadata on driver side.
Unfortunately it is solved only for SELECT statements, UPDATE/INSERT will be solved on separate occasion.
Core changes are in, we need to start working on driver side.
To Be Done:
SCYLLA_USE_METADATA_IDprotocol extension from SUPPORTED frame;METADATA_CHANGED(=3) flag in result metadata;Resolve skip metadata flag
Default value of skip metadata flag should be treated as
safest optionWhich means that if
SCYLLA_USE_METADATA_IDwas negotiated or CQL v5 is used then it is true, result metadata is skipped.In other cases it is false.
Changes
scyllaUseMetadataIdExtascqlProtocolExtensioninterface (ensures protocol extension negotiation)framerto havescyllaUseMetadataIdflag set if the extension was negotiatedscyllaUseMetadataIdflag to:resultMetadataIDduring writing of EXECUTE frame andresultMetadataIDduring parsing of RESULT (prepared) frame