Skip to content

Deps: update Netty to 4.1.109 #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2024
Merged

Conversation

mykaul
Copy link

@mykaul mykaul commented Apr 25, 2024

Fixes: #288

@mykaul mykaul added the dependencies Pull requests that update a dependency file label Apr 25, 2024
@mykaul
Copy link
Author

mykaul commented Apr 25, 2024

It's failing against Cassandra, with NPEs and such - is that a stable CI (and my change here is responsible for it) ?

@roydahan
Copy link
Collaborator

@Bouncheck / @k0machi are these 2 failures known to us (they look familiar to me):

Error:  Failures: 
Error:    DefaultLoadBalancingPolicyIT.should_apply_node_filter:252 expected:<[4]> but was:<[3]>
Error:    DefaultLoadBalancingPolicyIT.should_use_round_robin_on_local_dc_when_not_enough_routing_information:140 expected:<...e(endPoint=/127.0.0.[2:9042, hostId=6e3517ea-3c17-4fac-bdb2-707bcb488050, hashCode=1d6df1a4])> but was:<...e(endPoint=/127.0.0.[1:9042, hostId=9fdc4d7d-7a54-4971-a977-9544b4fef53b, hashCode=13aa0da1])>
[INFO] 

@mykaul
Copy link
Author

mykaul commented May 1, 2024

@Bouncheck , @roydahan - anything I need to do here to move forward?

@roydahan
Copy link
Collaborator

roydahan commented May 1, 2024

@mykaul no, it's on @Bouncheck.

Copy link
Collaborator

@Bouncheck Bouncheck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change itself LGTM. The DefaultLoadBalancingPolicyIT failures are flaky and seem to have common cause which is one of the nodes failing. This causes expected outputs in both methods to be different.

@roydahan roydahan merged commit d62b851 into scylladb:scylla-4.x May 6, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants