-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix IllegalState Attempting to use a Ccm rule while another is in use. This is disallowed
issue
#338
Conversation
85b905b
to
b50ae57
Compare
static final
IllegalState Attempting to use a Ccm rule while another is in use. This is disallowed
issue
If rule throw an exception on `before` it's `after` is not being executed. It needs to be respected in CustomCcmRule.
b50ae57
to
8a354fe
Compare
After the fix it shows all the correct errors:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change itself seems fine, but the test suite will still fail if the cause of the first exception throw is not addressed. In this case the ccm problem just flows downstream to those other tests.
Yes, but at least we won't get wrong error there. |
This suite was randomly failing with:
It happens when customCcmRule.before throws and exception.