Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IllegalState Attempting to use a Ccm rule while another is in use. This is disallowed issue #338

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

dkropachev
Copy link
Collaborator

@dkropachev dkropachev commented Sep 6, 2024

This suite was randomly failing with:

PreparedStatementCachingIT.should_invalidate_cache_entry_on_basic_udt_change_result_set » IllegalState Attempting to use a Ccm rule while another is in use.  This is disallowed
Error:    PreparedStatementCachingIT.should_invalidate_cache_entry_on_basic_udt_change_variable_defs » Runtime The command '[ccm, create, ccm_1, -i, 127.0.0., -n, 1:0, -v, release:6.1.1, --scylla, --config-dir=/tmp/ccm2069125928025678067]' failed to execute
Error:    PreparedStatementCachingIT.should_invalidate_cache_entry_on_collection_udt_change_result_set » IllegalState Attempting to use a Ccm rule while another is in use.  This is disallowed
Error:    PreparedStatementCachingIT.should_invalidate_cache_entry_on_collection_udt_change_variable_defs » IllegalState Attempting to use a Ccm rule while another is in use.  This is disallowed
Error:    PreparedStatementCachingIT.should_invalidate_cache_entry_on_nested_udt_change_result_set » IllegalState Attempting to use a Ccm rule while another is in use.  This is disallowed
Error:    PreparedStatementCachingIT.should_invalidate_cache_entry_on_nested_udt_change_variable_defs » IllegalState Attempting to use a Ccm rule while another is in use.  This is disallowed
Error:    PreparedStatementCachingIT.should_invalidate_cache_entry_on_tuple_udt_change_result_set » IllegalState Attempting to use a Ccm rule while another is in use.  This is disallowed
Error:    PreparedStatementCachingIT.should_invalidate_cache_entry_on_tuple_udt_change_variable_defs » IllegalState Attempting to use a Ccm rule while another is in use.  This is disallowed

It happens when customCcmRule.before throws and exception.

@dkropachev dkropachev self-assigned this Sep 6, 2024
@dkropachev dkropachev force-pushed the dk/fix-prepared-statement-caching-suit branch 2 times, most recently from 85b905b to b50ae57 Compare September 6, 2024 03:45
@dkropachev dkropachev changed the title Make ccmRule static final Fix IllegalState Attempting to use a Ccm rule while another is in use. This is disallowed issue Sep 6, 2024
If rule throw an exception on `before` it's `after` is not being
executed.
It needs to be respected in CustomCcmRule.
@dkropachev dkropachev force-pushed the dk/fix-prepared-statement-caching-suit branch from b50ae57 to 8a354fe Compare September 6, 2024 04:32
@dkropachev
Copy link
Collaborator Author

After the fix it shows all the correct errors:

Error:  Errors: 
Error:    HeapCompressionIT » Runtime The command '[ccm, create, ccm_1, -i, 127.0.0., -n, 1:0, -v, release:6.1.1, --scylla, --config-dir=/tmp/ccm1188420823062558242]' failed to execute
Error:    NettyResourceLeakDetectionIT » Runtime The command '[ccm, create, ccm_1, -i, 127.0.0., -n, 1:0, -v, release:6.1.1, --scylla, --config-dir=/tmp/ccm385967332069726971]' failed to execute
Error:    PreparedStatementCachingIT.should_invalidate_cache_entry_on_basic_udt_change_result_set » Runtime The command '[ccm, create, ccm_1, -i, 127.0.0., -n, 1:0, -v, release:6.1.1, --scylla, --config-dir=/tmp/ccm31461175664616730]' failed to execute
Error:    PreparedStatementCachingIT.should_invalidate_cache_entry_on_basic_udt_change_variable_defs » Runtime The command '[ccm, create, ccm_1, -i, 127.0.0., -n, 1:0, -v, release:6.1.1, --scylla, --config-dir=/tmp/ccm7181374279822787264]' failed to execute
Error:    PreparedStatementCachingIT.should_invalidate_cache_entry_on_collection_udt_change_result_set » Runtime The command '[ccm, create, ccm_1, -i, 127.0.0., -n, 1:0, -v, release:6.1.1, --scylla, --config-dir=/tmp/ccm8158528556485929033]' failed to execute
Error:    PreparedStatementCachingIT.should_invalidate_cache_entry_on_collection_udt_change_variable_defs » Runtime The command '[ccm, create, ccm_1, -i, 127.0.0., -n, 1:0, -v, release:6.1.1, --scylla, --config-dir=/tmp/ccm3873555618150795371]' failed to execute
Error:    PreparedStatementCachingIT.should_invalidate_cache_entry_on_nested_udt_change_result_set » Runtime The command '[ccm, create, ccm_1, -i, 127.0.0., -n, 1:0, -v, release:6.1.1, --scylla, --config-dir=/tmp/ccm8128550447679757588]' failed to execute
Error:    PreparedStatementCachingIT.should_invalidate_cache_entry_on_nested_udt_change_variable_defs » Runtime The command '[ccm, create, ccm_1, -i, 127.0.0., -n, 1:0, -v, release:6.1.1, --scylla, --config-dir=/tmp/ccm3434097862407988105]' failed to execute
Error:    PreparedStatementCachingIT.should_invalidate_cache_entry_on_tuple_udt_change_result_set » Runtime The command '[ccm, create, ccm_1, -i, 127.0.0., -n, 1:0, -v, release:6.1.1, --scylla, --config-dir=/tmp/ccm831209074042209573]' failed to execute
Error:    PreparedStatementCachingIT.should_invalidate_cache_entry_on_tuple_udt_change_variable_defs » Runtime The command '[ccm, create, ccm_1, -i, 127.0.0., -n, 1:0, -v, release:6.1.1, --scylla, --config-dir=/tmp/ccm3283683500438070482]' failed to execute
Error:    MockResolverIT » Runtime The command '[ccm, create, ccm_1, -i, 127.0.0., -n, 1:0, -v, release:6.1.1, --scylla, --config-dir=/tmp/ccm6752273638719243409]' failed to execute
Error:    DefaultSslEngineFactoryPropertyBasedWithClientAuthIT » Runtime The command '[ccm, create, ccm_1, -i, 127.0.0., -n, 1:0, -v, release:6.1.1, --scylla, --config-dir=/tmp/ccm3635914717585058183]' failed to execute

Copy link
Collaborator

@Bouncheck Bouncheck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change itself seems fine, but the test suite will still fail if the cause of the first exception throw is not addressed. In this case the ccm problem just flows downstream to those other tests.

@dkropachev dkropachev merged commit 4200ef8 into scylla-4.x Sep 6, 2024
9 of 12 checks passed
@dkropachev
Copy link
Collaborator Author

Change itself seems fine, but the test suite will still fail if the cause of the first exception throw is not addressed. In this case the ccm problem just flows downstream to those other tests.

Yes, but at least we won't get wrong error there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants