Skip to content

Conversation

@dkropachev
Copy link

@dkropachev dkropachev commented Dec 9, 2025

The goal is to fixe ~8 vulnurabilities that comming from guava dependency.
This PR does the following:

  1. Drops GuavaCompatibility
  2. Updates documentation to reflect that it targets only one version of guava
  3. Updates guava to 33.3.1-jre

It fixes ~8 vulnurabilities that comming from guava dependency.
@dkropachev dkropachev changed the title Update guava to 33.3.1-jre 3.x: Update guava to 33.3.1-jre Dec 9, 2025
@dkropachev dkropachev marked this pull request as ready for review December 9, 2025 02:11
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Guava dependency from version 19.0 to 33.3.1-jre to address approximately 8 security vulnerabilities. The update includes removing legacy compatibility code for older Guava versions (< 19.0) and migrating from deprecated APIs to their modern equivalents.

  • Updates Guava dependency version from 19.0 to 33.3.1-jre
  • Removes legacy compatibility layer for Guava versions below 19.0
  • Migrates from deprecated immediateCheckedFuture to immediateFuture API

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
pom.xml Updates Guava version property and Javadoc API documentation link to 33.3.1-jre
driver-core/src/main/java/com/datastax/driver/core/GuavaCompatibility.java Removes legacy Guava < 19 compatibility code, simplifies version detection, removes unused imports, and updates documentation
driver-core/src/test/java/com/datastax/driver/core/AbstractReconnectionHandlerTest.java Migrates from deprecated Futures.immediateCheckedFuture() to Futures.immediateFuture()

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Driver do not support old guavas anymore, on modern guavas API
look-alike, we don't need this layer anymore.
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 31 out of 31 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dkropachev dkropachev requested a review from nikagra December 22, 2025 09:21
@dkropachev
Copy link
Author

@sylwiaszunejko , could you please take a look at it

@dkropachev dkropachev merged commit e245f83 into scylladb:scylla-3.x Dec 22, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants