-
Notifications
You must be signed in to change notification settings - Fork 39
3.x: Update guava to 33.3.1-jre #774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.x: Update guava to 33.3.1-jre #774
Conversation
It fixes ~8 vulnurabilities that comming from guava dependency.
driver-core/src/main/java/com/datastax/driver/core/GuavaCompatibility.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/java/com/datastax/driver/core/GuavaCompatibility.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the Guava dependency from version 19.0 to 33.3.1-jre to address approximately 8 security vulnerabilities. The update includes removing legacy compatibility code for older Guava versions (< 19.0) and migrating from deprecated APIs to their modern equivalents.
- Updates Guava dependency version from 19.0 to 33.3.1-jre
- Removes legacy compatibility layer for Guava versions below 19.0
- Migrates from deprecated
immediateCheckedFuturetoimmediateFutureAPI
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pom.xml | Updates Guava version property and Javadoc API documentation link to 33.3.1-jre |
| driver-core/src/main/java/com/datastax/driver/core/GuavaCompatibility.java | Removes legacy Guava < 19 compatibility code, simplifies version detection, removes unused imports, and updates documentation |
| driver-core/src/test/java/com/datastax/driver/core/AbstractReconnectionHandlerTest.java | Migrates from deprecated Futures.immediateCheckedFuture() to Futures.immediateFuture() |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Driver do not support old guavas anymore, on modern guavas API look-alike, we don't need this layer anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 31 out of 31 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@sylwiaszunejko , could you please take a look at it |
The goal is to fixe ~8 vulnurabilities that comming from guava dependency.
This PR does the following:
GuavaCompatibility33.3.1-jre