Fix some typos in JSON files and markdown formatting issues#15
Open
matus-cuper wants to merge 1 commit intoscylladb:masterfrom
Open
Fix some typos in JSON files and markdown formatting issues#15matus-cuper wants to merge 1 commit intoscylladb:masterfrom
matus-cuper wants to merge 1 commit intoscylladb:masterfrom
Conversation
izhukov1992
reviewed
Mar 31, 2021
documentation/QUICKSTART.md
Outdated
| --broker-list localhost:9092 | ||
| --topic topic1 | ||
| --property parse.key=true | ||
| --property key.schema='{"type":"record",name":"key_schema","fields":[{"name":"id","type":"int"}]}' |
There was a problem hiding this comment.
Yeah! I was getting an issue because of missing double quote before "name" attribute as well
izhukov1992
reviewed
Mar 31, 2021
| --topic topic1 \ | ||
| --property parse.key=true \ | ||
| --property key.schema='{"type":"record","name":"key_schema","fields":[{"name":"id","type":"int"}]}' \ | ||
| --property "key.separator=$" \ |
There was a problem hiding this comment.
I prefer:
--property key.separator="$"
I checked it on my side and it works too but look better for me
dkropachev
force-pushed
the
master
branch
5 times, most recently
from
9d34a52 to
7a244f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve markdown formatting and fix JSON examples